refine paddle_merge_model #4473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xreki
reviewed
Oct 26, 2017
| @@ -28,7 +29,8 @@ using namespace std; // NOLINT | |||
| int main(int argc, char** argv) { | |||
| initMain(argc, argv); | |||
| initPython(argc, argv); | |||
| string confFile = TrainerConfigHelper::getConfigNameFromPath(FLAGS_model_dir); | |||
|
|
|||
There was a problem hiding this comment.
在这里加个对参数的检查吧：
if (FLAGS_model_dir.empty() || FLAGS_config_file.empty() || FLAGS_model_file.empty()) {
LOG(INFO) << "Usage: ./paddle_merge_model --model_dir=pass-00000 --config_file=config.py --model_file=model.paddle";
return;
}
| @@ -19,7 +19,7 @@ import "ModelConfig.proto"; | |||
| package paddle; | |||
|
|
|||
| message OptimizationConfig { | |||
| required int32 batch_size = 3; | |||
| optional int32 batch_size = 3 [ default = 1 ]; | |||
There was a problem hiding this comment.
使用ModelConfig之后，这里的修改是不是不需要了。
Xreki
approved these changes
Oct 26, 2017
| @@ -19,7 +19,7 @@ import "ModelConfig.proto"; | |||
| package paddle; | |||
|
|
|||
| message OptimizationConfig { | |||
| required int32 batch_size = 3; | |||
| optional int32 batch_size = 3 [ default = 1 ]; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4465