Make PyBind support C++ exception #4396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiayiFeng
reviewed
Sep 26, 2017
| class TestException(unittest.TestCase): | ||
| def test_exception(self): | ||
| self.assertRaises(core.EnforceNotMet, | ||
| lambda: core.__unittest_throw_exception__()) |
There was a problem hiding this comment.
How could we get and check the error message? Use .message?
It will be better to add another unit test of the error message here.
…ython_catch_enforce_not_met
jacquesqiao
reviewed
Sep 26, 2017
| namespace paddle { | ||
| namespace pybind { | ||
|
|
||
| extern void BindException(pybind11::module& m); |
There was a problem hiding this comment.
extern is not necessary but useful for code reading.
…ython_catch_enforce_not_met
…ython_catch_enforce_not_met
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4451