Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add move construct for KernelSignature #42253

Merged
merged 2 commits into from
Apr 27, 2022

Conversation

zyfncg
Copy link
Contributor

@zyfncg zyfncg commented Apr 25, 2022

PR types

Others

PR changes

Others

Describe

KernelSignature添加移动构造函数和移动赋值函数。

@paddle-bot-old
Copy link

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

KernelSignature& operator=(const KernelSignature& other) {
name = other.name;
input_names = other.input_names;
attr_names = other.attr_names;
output_names = other.output_names;
return *this;
}

KernelSignature& operator=(KernelSignature&& other) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

移动构造和移动赋值需要加 noexcept

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks!

@zyfncg zyfncg merged commit e5a0365 into PaddlePaddle:develop Apr 27, 2022
@zyfncg zyfncg deleted the opt_kernel_signature branch April 27, 2022 02:09
zyfncg added a commit to zyfncg/Paddle that referenced this pull request Apr 27, 2022
* add move construct for KernelSignature

* add noexcept
phlrain pushed a commit that referenced this pull request Apr 28, 2022
* Optimize the performanece of sum api (#42231)

* optimize the performanece of sum api

* optimize IsDenseTensorInput

* remove debug log

* Add move construct for KernelSignature (#42253)

* add move construct for KernelSignature

* add noexcept

* fix cherry-pick problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants