Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add flatten2,reshape2,squueze2_trt_fuse_pass test cast #41031

Merged
merged 3 commits into from
Mar 31, 2022
Merged

add flatten2,reshape2,squueze2_trt_fuse_pass test cast #41031

merged 3 commits into from
Mar 31, 2022

Conversation

heliqi
Copy link
Contributor

@heliqi heliqi commented Mar 28, 2022 •
edited
Loading

PR types

Others

PR changes

Others

Describe

涉及 trt_flatten2_matmul_fuse_pass、trt_reshape2_matmul_fuse_pass、trt_squeeze2_matmul_fuse_pass三个pass:

  1. 限制三个pass的matmul输入Y必须为权重，修复非权重报错问题
  2. 增加三个pass的TRT单测， 修改三个Pass的cpu、gpu单测
  3. 修复禁用日志还是打印pass相关日志问题

@paddle-bot-old
Copy link

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

XieYunshen
XieYunshen approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
单测设置超时时间，设置的超时阈值不合理，后续有PR修改

@heliqi
Copy link
Contributor Author

heliqi commented Mar 31, 2022

LGTM 单测设置超时时间，设置的超时阈值不合理，后续有PR修改

linux的ci虽然只要16s左右，但是windows的ci必须要120s+,所以只能设置的比较大

jiangjiajun
jiangjiajun approved these changes Mar 31, 2022
View reviewed changes
Copy link
Collaborator

@jiangjiajun jiangjiajun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiangjiajun jiangjiajun merged commit 7ef6920 into PaddlePaddle:develop Mar 31, 2022
@heliqi heliqi deleted the liqi_develop branch April 2, 2022 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiangjiajun jiangjiajun jiangjiajun approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heliqi @jiangjiajun @XieYunshen