Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Phi] Move Rnn Op from fluid to phi #41007

Merged
merged 8 commits into from
Mar 30, 2022
Merged

[Phi] Move Rnn Op from fluid to phi #41007

merged 8 commits into from
Mar 30, 2022

Conversation

zyfncg
Copy link
Contributor

@zyfncg zyfncg commented Mar 28, 2022

PR types

Others

PR changes

Others

Describe

Move kerne and infershape of rnn op from fluid to phi.

@paddle-bot-old
Copy link

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

chenwhql
chenwhql previously approved these changes Mar 28, 2022
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}

template <typename T>
void create_mask_matrix(const CPUContext& dev_ctx,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

顺便改为使用驼峰式命名?

Copy link
Contributor Author

@zyfncg zyfncg Mar 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

paddle/phi/kernels/cpu/rnn_functor.h Outdated Show resolved Hide resolved
@@ -647,7 +647,6 @@ void BindImperative(py::module *m_ptr) {
} else {
act_name = name.cast<std::string>();
}
VLOG(4) << "Init VarBase :" << act_name;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

log为何删除

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是之前的PR引入的debug信息,作用不大所以删掉了

@@ -0,0 +1,393 @@
// Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文件名为何叫.cu.cc,直接.cu怎么样

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个算子原来使用的就是.cu.cc,可能是为了加速编译,这里保持了原来的文件格式

Copy link
Contributor

@MingMingShangTian MingMingShangTian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyfncg zyfncg merged commit 66cf8b0 into PaddlePaddle:develop Mar 30, 2022
@zyfncg zyfncg deleted the rnn branch March 30, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants