Add Sparse op sparse_relu #40959
Merged
Add Sparse op sparse_relu #40959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 24, 2022 07:17
|
✅ This PR's description meets the template requirements! |
|
你的PR提交成功，感谢你对开源项目的贡献! |
xingfeng01
previously approved these changes
Mar 28, 2022
| SparseCooTensor* out); | ||
|
|
||
| template <typename T, typename Context> | ||
| SparseCooTensor SparseRelu(const Context& dev_ctx, const SparseCooTensor& x) { |
There was a problem hiding this comment.
是的，这里不能直接在前端通过SparseCooTensor的values熟悉来调用dense的relu的原因主要是：1. SparseCooTensor是在后端进行封装的，2. 动态图的autograd属性在API Tensor中，不在后端的DenseTensor里。
added 2 commits
March 28, 2022 08:08
Aurelius84
approved these changes
Mar 29, 2022
wanghuancoder
approved these changes
Mar 29, 2022
chenwhql
approved these changes
Mar 29, 2022
| See the License for the specific language governing permissions and | ||
| limitations under the License. */ | ||
|
|
||
| #include "paddle/phi/kernels/sparse/sparse_activation_grad_kernel.h" |
There was a problem hiding this comment.
这个文件命名是不是有点冗余，sparse目录下，还需要sparse_的前缀吗
xingfeng01
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
sparse_kernel改成sparse