[PHI] Remove infershape of set_value op #40636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… remove_set_value_infershape
chenwhql
approved these changes
Mar 17, 2022
| @@ -1090,6 +1090,16 @@ void RollInferMeta(const MetaTensor& x, | |||
| out->set_dtype(x.dtype()); | |||
| } | |||
|
|
|||
| void SetValueInferMeta(const MetaTensor& x, MetaTensor* out) { | |||
There was a problem hiding this comment.
这个infermeta的参数和kernel参数也不一致吧，后续自动生成到generator.h/cc中的infermeta会和这个函数重名吗
There was a problem hiding this comment.
这里需要补充下对out dims和dtype的推断吗？虽然原来的没写，但这里应该有？
There was a problem hiding this comment.
这里是先绕过了给算子注册两个InferMeta函数的问题，参数不一致的问题可以在自动生成的时候处理，函数名重名的问题到时候一并解决。
set_value算子是inplace的，正常的话InferMeta里确实也不需要设置，为了稳妥起见迁过来也没有设置dim和dtype，后面有时间再把这里补上测试下
YuanRisheng
approved these changes
Mar 17, 2022
MingMingShangTian
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Remove infershape of set_value op and add infermeta for set_value in phi