Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PADDLE_WITH_XPU2 with PADDLE_WITH_KP #40560

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

AnnaTrainingG
Copy link
Contributor

@AnnaTrainingG AnnaTrainingG commented Mar 15, 2022

PR types

Others

PR changes

Others

Describe

Replace PADDLE_WITH_XPU2 with PADDLE_WITH_KP
1.将Reduce中的XPU宏统一替换为PADDLE_WITH_KP
2.头文件控制开启__xpu__
3.将ReduceAnyKernel中的store替换为WriteData

OP-benchmark异常说明
1.本次修改仅针对reduce XPU 和GPU,不设计API 实现调整,与其他OP实现无关
2.出错case与本次修改无关,重新re-run 影响的OP 不同
lgamma_0 (backward) 调用的是Kerenl Elementwise,修改Reduce并不会对其造成性能影响
multiply_8 (forward) 调用的是Kerenl Elementwise,修改Reduce并不会对其造成性能影响

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for op benchmark

@AnnaTrainingG AnnaTrainingG merged commit c142e37 into PaddlePaddle:develop Mar 17, 2022
liqitong-a pushed a commit to liqitong-a/Paddle that referenced this pull request Mar 17, 2022
* Replace PADDLE_WITH_XPU2 with PADDLE_WITH_KP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants