-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Phi]Move Tanh/BRelu/LeakyRelu/ThresholdedRelu Kernels to Phi #40385
[Phi]Move Tanh/BRelu/LeakyRelu/ThresholdedRelu Kernels to Phi #40385
Conversation
Thanks for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
const ArgumentMappingContext& ctx) { \ | ||
return KernelSignature( \ | ||
op_name "_grad", {"X", GradVarName("Out")}, {}, {GradVarName("X")}); \ | ||
#define DefineActGradDepXOpArgMap(func_name, op_name, attrs) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
宏是不是用大写,统一风格比较好
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的下个PR修改
dev_ctx, &x, nullptr, &dout, dx, functor); \ | ||
} | ||
|
||
#define DEFINE_CPU_ACT_GRAD_KERNEL_WITH_ONE_ATTRS_DepX( \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
宏里面是不是全大写规范一些?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下个pr修复
PR types
Others
PR changes
Others
Describe
将activation op下的 Tanh/BRelu/LeakyRelu/ThresholdedRelu移动到Phi下。