Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the typo of the param description in sequence_conv_pool #4034

Merged
merged 12 commits into from
Sep 17, 2017
Merged

fix the typo of the param description in sequence_conv_pool #4034

merged 12 commits into from
Sep 17, 2017

Conversation

peterzhang2029
Copy link
Contributor

resolve #4033

@luotao1
Copy link
Contributor

luotao1 commented Sep 12, 2017

Please use pre-commit to pass the check-stype of travis-ci.

lcy-seso
lcy-seso reviewed Sep 16, 2017
View reviewed changes
Copy link
Contributor

@lcy-seso lcy-seso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work, and please delete the unused comments.

python/paddle/trainer_config_helpers/networks.py Outdated

"""
# from activations import *
from activations import LinearActivation, ReluActivation, SoftmaxActivation, \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delete line 14 ~ 17

lcy-seso
lcy-seso approved these changes Sep 17, 2017
View reviewed changes
Copy link
Contributor

@lcy-seso lcy-seso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lcy-seso lcy-seso merged commit 8c71e09 into PaddlePaddle:develop Sep 17, 2017
@peterzhang2029 peterzhang2029 deleted the my-paddle branch September 18, 2017 03:22
@peterzhang2029 peterzhang2029 restored the my-paddle branch September 18, 2017 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcy-seso lcy-seso lcy-seso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the typo of the param description in sequence_conv_pool
3 participants
@peterzhang2029 @luotao1 @lcy-seso