[phi] move shape op #40248
Merged
[phi] move shape op #40248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zyfncg
reviewed
Mar 10, 2022
YuanRisheng
reviewed
Mar 10, 2022
chenwhql
approved these changes
Mar 10, 2022
chenwhql
reviewed
Mar 10, 2022
| void ShapeKernel(const Context& ctx, | ||
| const SelectedRows& input, | ||
| DenseTensor* out) { | ||
| auto in_var = input; |
There was a problem hiding this comment.
日升的建议是合理的，这段代码改成ShapeKernel<T, Context >(dev_ctx, input.value(), out);，是不是逻辑一样？
|
|
||
| namespace phi { | ||
|
|
||
| template <typename T, typename Context> |
There was a problem hiding this comment.
这个是不是可以向reshape一样直接放到kernels目录下呢，shape在每个设备上的实现都是一样的
xingfeng01
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
[phi] move shape op