Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove isinstance Dataset check #40184

Merged
merged 1 commit into from
Mar 8, 2022
Merged

remove isinstance Dataset check #40184

merged 1 commit into from
Mar 8, 2022

Conversation

heavengate
Copy link
Contributor

@heavengate heavengate commented Mar 4, 2022 •
edited
Loading

PR types

Function optimization

PR changes

APIs

Describe

remove isinstance(dataset, Dataset) check in DataLoader and BatchSampler for compatible for HuggingFace dataset API

@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 4, 2022

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@heavengate heavengate changed the title remove isinstance Dataset check. test=develop remove isinstance Dataset check Mar 7, 2022
guoshengCS
guoshengCS approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@guoshengCS guoshengCS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heavengate heavengate merged commit 2ce007c into PaddlePaddle:develop Mar 8, 2022
@heavengate heavengate deleted the remove_dataset_assert branch March 8, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guoshengCS guoshengCS guoshengCS approved these changes

@qingqing01 qingqing01 Awaiting requested review from qingqing01

@LielinJiang LielinJiang Awaiting requested review from LielinJiang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heavengate @guoshengCS