[Phi] move truncated_gaussian_random kernel #39971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zyfncg
approved these changes
Feb 28, 2022
|
|
||
| namespace phi { | ||
|
|
||
| KernelSignature TruncatedGaussianRandomOpArgumentMapping( |
There was a problem hiding this comment.
这个ArgumentMapping感觉可以不写，直接使用默认op_proto生成的应该也能work，可以在后续的PR去掉试试
There was a problem hiding this comment.
开始没写这个，会报错。后续 PR 再尝试看看是否可以去掉。
YuanRisheng
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
OPs
Describe
[Phi] move truncated_gaussian_random kernel
还有两个有待后续完善的地方：