[Phi] move flip op to phi kernel #39822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
chenwhql
reviewed
Feb 23, 2022
paddle/phi/kernels/flip_kernel.h
Outdated
|
|
||
| #include <vector> | ||
| #include "paddle/phi/core/dense_tensor.h" | ||
| #include "paddle/phi/core/device_context.h" |
There was a problem hiding this comment.
device_context这个头文件不加也可以，这里没用到
| #include "paddle/fluid/platform/place.h" | ||
| #include "paddle/phi/backends/gpu/gpu_context.h" | ||
| #include "paddle/phi/core/kernel_registry.h" | ||
| #include "paddle/phi/kernels/flip_kernel.h" |
There was a problem hiding this comment.
建议#include "paddle/phi/kernels/flip_kernel.h"放到最上面，和下面用空行隔开，如style规范示例：
|
|
||
| #include "paddle/fluid/memory/malloc.h" | ||
| #include "paddle/fluid/memory/memcpy.h" | ||
| #include "paddle/fluid/platform/place.h" |
There was a problem hiding this comment.
place这个建议换成phi的#include "paddle/phi/common/place.h"
| const std::vector<int>& axis, | ||
| DenseTensor* out) { | ||
| const auto gplace = dev_ctx.GetPlace(); | ||
| auto cplace = paddle::platform::CPUPlace(); |
There was a problem hiding this comment.
paddle::platform::CPUPlace();建议用phi::CPUPlace
There was a problem hiding this comment.
@chenwhql thx 都已修改重跑 ci
MingMingShangTian
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
迁移算子库