Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PTen->Phi PR2] Rename PT_REGISTER macro to PD_REGISTER #39790

Merged
merged 3 commits into from
Feb 22, 2022
Merged

[PTen->Phi PR2] Rename PT_REGISTER macro to PD_REGISTER #39790

merged 3 commits into from
Feb 22, 2022

Conversation

chenwhql
Copy link
Contributor

@chenwhql chenwhql commented Feb 21, 2022 •
edited
Loading

PR types

Function optimization

PR changes

Others

Describe

[PTen->Phi PR2] Rename PT_REGISTER macro to PD_REGISTER

PT_REGISTER_XXX中的PT取自Pten的前两个字母，现在pten已经替换为phi，这里仍然使用PT意义不明，本PR统一替换为PD

为什么替换为PD，理由如下：

  • 使用paddle的简称PD，比PHI简洁一些，也更直观能看出是paddle
  • 自2.0.1开始，已经有以PD为前缀的对外API上线了，与之前的API统一前缀，体验更好，之前自定义算子有一系列PD为前缀的注册宏，包括
    • PD_BUILD_OP， PD_BUILD_GRAD_OP，PD_BUILD_DOUBLE_GRAD_OP
    • PD_DISPATCH_FLOATING_TYPES，PD_DISPATCH_INTEGRAL_TYPES，...

【相关工作】

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

XiaoguangHu01
XiaoguangHu01 approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

raindrops2sea
raindrops2sea approved these changes Feb 22, 2022
View reviewed changes
Copy link
Collaborator

@raindrops2sea raindrops2sea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenwhql chenwhql merged commit 4a33879 into PaddlePaddle:develop Feb 22, 2022
This was referenced Feb 23, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raindrops2sea raindrops2sea raindrops2sea approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenwhql @raindrops2sea @XiaoguangHu01