Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DistributedFusedLamb alignment bug #39747

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Fix DistributedFusedLamb alignment bug #39747

merged 1 commit into from
Feb 21, 2022

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Feb 19, 2022

PR types

Bug fixes

PR changes

OPs

Describe

Fix the bug that the numel of the fused tensor inside DistributedFusedLamb op should be a factor of alignment * nranks instead of lcm(alignment, nranks).

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

limin2021
limin2021 approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@limin2021 limin2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sneaxiy sneaxiy merged commit 65ced1f into PaddlePaddle:develop Feb 21, 2022
@sneaxiy sneaxiy deleted the fix_alignment branch February 21, 2022 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limin2021 limin2021 limin2021 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sneaxiy @limin2021