-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pten] Gru lstm migration #39729
[Pten] Gru lstm migration #39729
Conversation
Thanks for your contribution! |
…le non .cu files in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,一些命名空间后续PR可以追加修改为phi下面的
LstmMetaValue<T> value, LstmMetaGrad<T> grad, | ||
int frame_size, int batch_size, T cell_clip, | ||
ActivationType active_node, ActivationType active_gate, | ||
void gpu_lstm_backward(const paddle::platform::DeviceContext& context, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paddle::platform::DeviceContext -> phi::DeviceContext
@@ -237,21 +298,37 @@ void gpu_lstm_backward(const platform::DeviceContext& context, Op op, | |||
} | |||
|
|||
auto stream = | |||
reinterpret_cast<const platform::CUDADeviceContext&>(context).stream(); | |||
reinterpret_cast<const paddle::platform::CUDADeviceContext&>(context) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paddle::platform::CUDADeviceContext -> phi::GPUContext
@@ -59,32 +61,37 @@ class LoDTensor2BatchFunctor { | |||
|
|||
public: | |||
void operator()(const DeviceContext& context, | |||
const framework::LoDTensor& lod_tensor, | |||
framework::LoDTensor* batch, bool is_cal_batch_lod, | |||
const paddle::framework::LoDTensor& lod_tensor, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paddle::framework::LoDTensor -> DenseTensor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Others
PR changes
Others
Describe