Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug of paddle.to_tensor and paddle.moveaxis #39662

Merged
merged 3 commits into from
Mar 1, 2022
Merged

fix bug of paddle.to_tensor and paddle.moveaxis #39662

merged 3 commits into from
Mar 1, 2022

Conversation

zhwesky2010
Copy link
Contributor

@zhwesky2010 zhwesky2010 commented Feb 17, 2022 •
edited
Loading

PR types

Bug fixes

PR changes

APIs

Describe

修复三个API bug：

  1. paddle.to_tensor指定Tensor到不同的card上，在双卡环境下，to_tensor无法通过palce参数指定数据所在的卡 #39126
  2. paddle.to_tensor(1)在Linux/mac上默认是int64，Windows上默认是int32，此处进行了统一，关于windows下使用softmax_with_cross_entropy报错 #39828
  3. paddle.moveaxis支持complex64/complex128类型

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhwesky2010 zhwesky2010 changed the title support allocate Tensor on specified place fix bug of paddle.to_tensor and paddle.moveaxis Feb 24, 2022
@Ligoml Ligoml mentioned this pull request Feb 24, 2022
Closed
@zhwesky2010 zhwesky2010 force-pushed the fix_to_tensor branch 2 times, most recently from 72b9b61 to a99b4a1 Compare February 25, 2022 08:03
jeff41404
jeff41404 previously approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 requested a review from zhiqiu February 28, 2022 14:44
@zhwesky2010 zhwesky2010 mentioned this pull request Feb 28, 2022
Closed
zhiqiu
zhiqiu approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit 4617c1b into PaddlePaddle:develop Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiu zhiqiu zhiqiu approved these changes

@jeff41404 jeff41404 jeff41404 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhwesky2010 @zhiqiu @jeff41404