[Pten] move paddle/operators/math/functors.h and compound_functors.h #39514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclementine
changed the title
|
Thanks for your contribution! |
iclementine
changed the title
iclementine
changed the title
chenwhql
approved these changes
Feb 15, 2022
| @@ -17,29 +17,31 @@ limitations under the License. */ | |||
| #include "paddle/fluid/operators/amp/fp16_type_traits.h" | |||
| #include "paddle/fluid/operators/math.h" | |||
There was a problem hiding this comment.
"paddle/fluid/operators/math.h" 目前其他同学在迁移。
| @@ -17,29 +17,31 @@ limitations under the License. */ | |||
| #include "paddle/fluid/operators/amp/fp16_type_traits.h" | |||
There was a problem hiding this comment.
这个里面的两个traits我觉得可以直接放pten/common/float16.h中
There was a problem hiding this comment.
赞成，这个类型的一些 function 和 trait 放在一起比较合理。
我后续加一个迁移 fp16_type_traits 的 PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe