Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bf16] change bf16 c++ print behavior #39370

Merged
merged 1 commit into from
Feb 8, 2022
Merged

[bf16] change bf16 c++ print behavior #39370

merged 1 commit into from
Feb 8, 2022

Conversation

zhiqiu
Copy link
Contributor

@zhiqiu zhiqiu commented Feb 7, 2022 •
edited
Loading

PR types

Breaking changes

PR changes

Others

Describe

[bf16] change bf16 print behavior

Original implementation prints bfloat number as uint16, this PR changes to float.
For example, bfloat number 1.0f is printed as 16256 before, and 1 now.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Feb 7, 2022

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhiqiu zhiqiu requested review from Aurelius84 and wozna and removed request for Aurelius84 February 7, 2022 10:00
wozna
wozna approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@wozna wozna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiqiu zhiqiu changed the title [bf16] change bf16 print behavior [bf16] change bf16 c++ print behavior Feb 7, 2022
zhangbo9674
zhangbo9674 approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@zhangbo9674 zhangbo9674 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiqiu zhiqiu mentioned this pull request Feb 7, 2022
Merged
@zhiqiu zhiqiu merged commit 96964ff into PaddlePaddle:develop Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wozna wozna wozna approved these changes

@zhangbo9674 zhangbo9674 zhangbo9674 approved these changes

@Aurelius84 Aurelius84 Awaiting requested review from Aurelius84

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiqiu @wozna @zhangbo9674