Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loss conversion from uint16 to float in ProgressBar class #39231

Conversation

ghost
Copy link

@ghost ghost commented Jan 25, 2022

PR types

Others

PR changes

Others

Describe

Enables correct printing of loss by the ProgressBar class when the datatype of loss is uint16.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@ghost ghost marked this pull request as draft January 25, 2022 17:00
@paddle-bot-old
Copy link

paddle-bot-old bot commented Feb 9, 2022

Sorry to inform you that 059e84c's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

@ghost ghost marked this pull request as ready for review February 15, 2022 09:36
arlesniak
arlesniak previously approved these changes Feb 16, 2022
Copy link
Contributor

@arlesniak arlesniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jakpiase
jakpiase previously approved these changes Feb 16, 2022
Copy link
Contributor

@jakpiase jakpiase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost dismissed stale reviews from jakpiase and arlesniak via 6d5f70c February 17, 2022 15:16
Copy link
Contributor

@arlesniak arlesniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jakpiase jakpiase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakpiase jakpiase added the BF16 label Feb 19, 2022
@lidanqing-intel
Copy link
Contributor

@Aganlengzi

Copy link
Contributor

@Aganlengzi Aganlengzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aganlengzi Aganlengzi merged commit 740cfa9 into PaddlePaddle:develop Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants