add number count op #39224
add number count op #39224
Conversation
|
Thanks for your contribution! |
|
Sorry to inform you that d249ceb's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
| from paddle.fluid.framework import in_dygraph_mode | ||
|
|
||
| __all__ = [ #noqa | ||
| 'expert_count' |
There was a problem hiding this comment.
这种属于对外暴露的接口，内部开发中的api不用放到__all__
开发中的api先放到paddle.incubate底下吧，
或者前面加下划线
paddle.distributed.utils._expert_count
| ] | ||
|
|
||
|
|
||
| def expert_count(gate_idx, n_expert): |
There was a problem hiding this comment.
这种op太专用了，能不能用通用的tensor操作的op来实现count功能？
会导致op数量过多，在做多硬件适配的时候是很大的负担。
There was a problem hiding this comment.
可以通过多个已有的通用tensor操作的组合实现，但是性能和显存上不如直接调用这种op算子更高效。
实际上，这个op的功能是对输入的数据计数，虽然命名带有expert前缀，但是相对来说还是比较通用的。我可以通过把这个OP名改成一个更合理的名字，使他成为一个通用的OP。
对于其他的算子，我们需要再斟酌一下。
add ut for expert_count
| from paddle.fluid.framework import in_dygraph_mode | ||
|
|
||
|
|
||
| def _number_count(gate_idx, upper_range): |
There was a problem hiding this comment.
OP定义与PR描述不符，另外PR描述过于简单，请说清该PR的作用与目的
|
|
||
| @unittest.skipIf(not core.is_compiled_with_cuda(), | ||
| "core is not compiled with CUDA") | ||
| class TestExpertCountAPI(unittest.TestCase): |
There was a problem hiding this comment.
OK，下个PR修改，MOE模块会有多个算子的PR需要提交
| @@ -0,0 +1,55 @@ | |||
| # Copyright (c) 2019 PaddlePaddle Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.
| @@ -0,0 +1,80 @@ | |||
| # Copyright (c) 2018 PaddlePaddle Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.
* add expert count op add ut for expert_count * update UT only for cuda * fix for rocm * update ut * add moe module * add expert count op add ut for expert_count * update UT only for cuda * update ut * add moe module * make expert count private * rename expert count op Co-authored-by: hlygit66666 <2570058140@qq.com>
PR types
New features
PR changes
OPs
Describe
新增 number count op该OP用于对输入的number计数
目前主要用于MOE中，作为对每个expert所处理的tokens计数