Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pten] remove deprecated fluid op kernel for pten #38842

Merged
merged 47 commits into from
Jan 26, 2022
Merged

[pten] remove deprecated fluid op kernel for pten #38842

merged 47 commits into from
Jan 26, 2022

Conversation

zhiqiu
Copy link
Contributor

@zhiqiu zhiqiu commented Jan 10, 2022 •
edited
Loading

PR types

New features

PR changes

OPs

Describe

[pten] update cmake file to remove fluid kernel

  • update cmake file for better generation of "USE_OP" in pybind.h to support operator without fluid cuda/cpu kernel
  • add add pten declaration.h to where pybind.h used
  • update dygraph op generator
  • fit eager legacy
  • update kernel choosing, to choose pten cpu kernel first if kernel of specific device not found

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

XieYunshen
XieYunshen previously approved these changes Jan 25, 2022
View reviewed changes
chenwhql
chenwhql previously approved these changes Jan 25, 2022
View reviewed changes
@zhiqiu zhiqiu dismissed stale reviews from chenwhql and XieYunshen via 2e61e81 January 25, 2022 12:44
chenwhql
chenwhql previously approved these changes Jan 25, 2022
View reviewed changes
chenwhql
chenwhql previously approved these changes Jan 26, 2022
View reviewed changes
chenwhql
chenwhql previously approved these changes Jan 26, 2022
View reviewed changes
XiaoguangHu01
XiaoguangHu01 approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phlrain phlrain self-requested a review January 26, 2022 10:08
@zhiqiu zhiqiu merged commit 3ab9aef into PaddlePaddle:develop Jan 26, 2022
@zhiqiu zhiqiu mentioned this pull request Jan 29, 2022
Merged
@zhiqiu zhiqiu mentioned this pull request Feb 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aurelius84 Aurelius84 Aurelius84 approved these changes

@chenwhql chenwhql chenwhql approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

@Ligoml Ligoml Ligoml approved these changes

@phlrain phlrain phlrain approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@jzhang533 jzhang533 jzhang533 left review comments

@raindrops2sea raindrops2sea raindrops2sea left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@zhiqiu @jzhang533 @Aurelius84 @chenwhql @XieYunshen @raindrops2sea @Ligoml @phlrain @XiaoguangHu01