Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Fix for MKLDNNDeviceContext error in matmul_v2_transpose_reshape fuse pass when GLOG_v set #38554

Merged
merged 2 commits into from
Dec 31, 2021

Conversation

jakpiase
Copy link
Contributor

@jakpiase jakpiase commented Dec 29, 2021

PR types

Bug fixes

PR changes

Others

Describe

Fix for MKLDNNDeviceContext error when GLOG_v env variable was set. It is a fix for #38038 and a reupload of #38411. All this PR does is skipping checking cache if it is empty

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jakpiase jakpiase added the Intel label Dec 29, 2021
@jakpiase
Copy link
Contributor Author

@pawelpiotrowicz Please review this PR

Copy link
Contributor

@pawelpiotrowicz pawelpiotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wozna wozna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakpiase
Copy link
Contributor Author

Hi @Aganlengzi could you please review and merge this PR?

@Aganlengzi
Copy link
Contributor

Hi @Aganlengzi could you please review and merge this PR?

@baoachun Plz help review and merge this PR~ for #38038 and #38411

Copy link
Contributor

@baoachun baoachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiweibo jiweibo merged commit 1d31764 into PaddlePaddle:develop Dec 31, 2021
@lidanqing-intel lidanqing-intel changed the title Fix for MKLDNNDeviceContext error in matmul_v2_transpose_reshape fuse pass when GLOG_v set [Bug fix] Fix for MKLDNNDeviceContext error in matmul_v2_transpose_reshape fuse pass when GLOG_v set Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants