[fleet_executor] Add task loop thread pool #38420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
wangxicoding
commented
Dec 24, 2021
| messages_.emplace_back(message); | ||
| } | ||
| if (empty) { | ||
| loop_->QueueInLoop([this]() { LoopOnce(); }); |
There was a problem hiding this comment.
后续可优化，同线程直接RunInLoop，不过貌似不是很打紧
wangxicoding
force-pushed
the
add_task_loop_thread_pool
branch
from
4a854c0
to
f62c676
Compare
LiYuRio
reviewed
Dec 24, 2021
| @@ -81,6 +81,16 @@ class BlockingQueue { | |||
| std::swap(*empty_queue, q_); | |||
| } | |||
|
|
|||
| std::deque<T> PopAll() { | |||
There was a problem hiding this comment.
上面那个PopAll应该没用了，应该可以直接删了
LiYuRio
reviewed
Dec 24, 2021
| void Start(); | ||
|
|
||
| TaskLoop* GetLoop(int tid); | ||
| std::vector<TaskLoop*> GetAllLoops(); |
There was a problem hiding this comment.
可以，目前这个还没有用。线程数少，里面保存的指针，应该也还能接收
LiYuRio
reviewed
Dec 24, 2021
| std::deque<InterceptorMessage> local_mailbox_; | ||
| std::mutex mutex_; | ||
| std::deque<InterceptorMessage> messages_; | ||
| // std::deque<InterceptorMessage> local_messages_; |
FeixLiu
reviewed
Dec 24, 2021
| std::deque<InterceptorMessage> local_mailbox_; | ||
| std::mutex mutex_; | ||
| std::deque<InterceptorMessage> messages_; | ||
| // std::deque<InterceptorMessage> local_messages_; |
There was a problem hiding this comment.
Delete this useless annotation?
| void QueueInLoop(Functor cb); | ||
|
|
||
| template <class F, class... Args> | ||
| auto Enqueue(F&& f, Args&&... args) |
There was a problem hiding this comment.
可以试试c++14的自动返回类型推倒，应该可以少点代码
| if (stop_) { | ||
| // break the pooling thread | ||
| VLOG(3) << "Interceptor " << interceptor_id_ << " is quiting."; | ||
| break; |
FeixLiu
reviewed
Dec 24, 2021
FeixLiu
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe