Refine clip_by_global_norm #38209
Merged
Refine clip_by_global_norm #38209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
… dev/clip_by_global_norm
… dev/clip_by_global_norm
zhwesky2010
reviewed
Dec 27, 2021
python/paddle/fluid/clip.py
Outdated
| if g.dtype == core.VarDesc.VarType.FP16 else clip_var) | ||
| new_grad = layers.elementwise_mul(x=g, y=clip_input) | ||
| params_and_grads.append((p, new_grad)) | ||
| if global_norm_var > max_global_norm: |
There was a problem hiding this comment.
建议在上面把 global_norm_var > max_global_norm 处理为一个bool flag，这样不用在循环里run多次compare OP
… dev/clip_by_global_norm
zhwesky2010
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
APIs
Describe
优化ClipByGlobalNorm性能：
以10*10的
paddle.nn.Linear为例，重复进行100轮优化，clip_by_global_nrom的调用耗时分析如下：（1）优化前：
（2）优化后：
优化前后耗时比为：0.77/0.54=1.43，优化29.9%。