Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Paddle-TRT] Fix deformable_conv_op_plugin de/serialization and refine the data type selection #38057

Merged
merged 1 commit into from
Dec 13, 2021
Merged

[Paddle-TRT] Fix deformable_conv_op_plugin de/serialization and refine the data type selection #38057

merged 1 commit into from
Dec 13, 2021

Conversation

zlsh80826
Copy link
Collaborator

PR types

Bug fixes

PR changes

Others

Describe

This PR fix some problem in deformable_conv_op_plugin.

  1. Fix the problem that hostBuffer is not updated in deserializeToDevice and serializeFromDevice
  2. This plugin doesn't support the running type is different with data_type_. (Many codes use data_type_ to determine the run type).
  3. The best practice for getOutputDataType return type is input_type.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

shangzhizhou
shangzhizhou approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@shangzhizhou shangzhizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shangzhizhou shangzhizhou merged commit 92ad682 into PaddlePaddle:develop Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shangzhizhou shangzhizhou shangzhizhou approved these changes

Assignees
No one assigned
Labels
NVIDIA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zlsh80826 @shangzhizhou