Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pscore geo&lr_decay #37995

Merged
merged 3 commits into from
Dec 10, 2021
Merged

fix pscore geo&lr_decay #37995

merged 3 commits into from
Dec 10, 2021

Conversation

zhaocaibei123
Copy link
Contributor

@zhaocaibei123 zhaocaibei123 commented Dec 9, 2021 •
edited
Loading

PR types

Bug fixes

PR changes

Others

Describe

  1. send op and append_send_op_pass fix: recover push sparse by send op except async mode
  2. push sparse scale_gradient fix: if input vars's dim[1] are not consistance, scale_gradient will not take effect now, we will move this function to op later

@paddle-bot-old
Copy link

paddle-bot-old bot commented Dec 9, 2021 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Dec 9, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhaocaibei123 zhaocaibei123 changed the title fix fix pscore geo&lr_decay Dec 9, 2021
@Thunderbrook Thunderbrook merged commit 513d1f9 into PaddlePaddle:develop Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thunderbrook Thunderbrook Thunderbrook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhaocaibei123 @Thunderbrook