Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearranged Eager AutoCodeGen directory structure #37812

Merged

Conversation

jim19930609
Copy link
Contributor

@jim19930609 jim19930609 commented Dec 3, 2021

PR types

New features

PR changes

Others

Describe

Rearranged Eager AutoCodeGen directory structure.

Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTM

@@ -30,26 +30,63 @@
DEFINE_bool(generate_all, false,
"Generate all operators currently registered in Paddle");

static std::unordered_map<std::string, paddle::framework::AttributeMap>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make all this into a namespace in next PR

paddle::platform::errors::Fatal("Unable to open op_list.txt file"));
}
}

namespace paddle {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this into another namespace and then using what u need

@JiabinYang JiabinYang merged commit c077de3 into PaddlePaddle:develop Dec 3, 2021
Zjq9409 pushed a commit to Zjq9409/Paddle that referenced this pull request Dec 10, 2021
* Rearranged Eager AutoCodeGen directory structure

* Removed USE_OP in Eager AutoCodeGen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants