add as_complex and as_real op #37784

iclementine · 2021-12-02T03:38:37Z

PR types

New features

PR changes

OPs

Describe

Add as_complex and as_real API, and corresponding operators.

examples

import paddle
x = paddle.arange(12, dtype=paddle.float32).reshape([2, 3, 2])
y = paddle.as_complex(x)
print(y.numpy())

# [[ 0. +1.j  2. +3.j  4. +5.j]
#  [ 6. +7.j  8. +9.j 10.+11.j]]

import paddle
x = paddle.arange(12, dtype=paddle.float32).reshape([2, 3, 2])
y = paddle.as_complex(x)
z = paddle.as_real(y)
print(z.numpy())

# [[[ 0.  1.]
#   [ 2.  3.]
#   [ 4.  5.]]

#  [[ 6.  7.]
#   [ 8.  9.]
#   [10. 11.]]]

fix typos in doc of angle_op

paddle-bot-old · 2021-12-02T03:39:03Z

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

jeff41404

lgtm

pangyoki · 2021-12-02T08:43:46Z

paddle/fluid/operators/complex_view_op.cc

+
+    const framework::DDim out_dims(in_dims.Get(), input_rank - 1);
+    ctx->SetOutputDim("Out", out_dims);
+    ctx->ShareLoD("X", /*->*/ "Out");


实数和对应的复数的lod是一样的吗？

实数和复数的 lod 是一样的。

对于 LoDTensor 来说，view_as_complex 和 view_as_real 直接操作 LoD Tensor 的 underlying Tensor.

比如说一个 underlying 形状为 (L, *base_shape) 的复数 LoDTensor 来说，经过 view_as_real 会得到一个 LoD Tensor, 其 underlying Tensor 形状为 (L, *base_shape, 2)。

而 LoD 信息表示的是递归折叠的端点信息。只要一个操作是局限在 base_shape 内部的操作，那么是不会改变 LoD 信息的，而复数和实数的互相 view，对于复数来说是 element 级别的操作，所以不会改变 LoD 信息。

对于 view_as_complex 来说，因为对输入 Tensor 形状有要求。假定为 (L, *base_shape), 那么每两个相邻的元素为一个单元视作复数，这个操作也不会跨越 base_shape, 所以不会改变 LoD 信息。

pangyoki · 2021-12-02T08:46:09Z

python/paddle/fluid/tests/unittests/test_complex_view_op.py

+    return np.stack([x.real, x.imag], -1)
+
+
+class TestViewAsComplexOp(OpTest):


请参考test_view_op_reuse_allocation.py单测，测试下这两个API的view机制是否真的生效（改变输入输出中的某一个tensor值，另一个也会随之改变），同时也测下inplace version等信息。
可以直接在test_view_op_reuse_allocation.py单测中添加新的样例。

加上了测试内存复用机制的单测 case.

…input's allocation

pangyoki

LGTM

jeff41404

lgtm

TCChenlong

LGTM

…ators

…_view

jeff41404

lgtm

TCChenlong

LGTM

XiaoguangHu01

LG API

TCChenlong

LGTM For API Docs

jeff41404

lgtm

XiaoguangHu01

LGTM

add view_ad_complex and view_as_real op

781cb04

jeff41404 previously approved these changes Dec 2, 2021

View reviewed changes

pangyoki reviewed Dec 2, 2021

View reviewed changes

add test cases to ensure view_as_complex and view_as_real reuses the …

5516c39

…input's allocation

iclementine dismissed jeff41404’s stale review via 5516c39 December 2, 2021 11:49

pangyoki previously approved these changes Dec 2, 2021

View reviewed changes

jeff41404 previously approved these changes Dec 2, 2021

View reviewed changes

phlrain self-requested a review December 2, 2021 12:35

phlrain previously approved these changes Dec 2, 2021

View reviewed changes

iclementine changed the title ~~add view_ad_complex and view_as_real op~~ add view_as_complex and view_as_real op Dec 3, 2021

TCChenlong previously approved these changes Dec 3, 2021

View reviewed changes

iclementine dismissed stale reviews from TCChenlong, phlrain, jeff41404, and pangyoki via a856076 December 8, 2021 11:08

rename op and api, remove inplace and view machanism for these 2 oper…

0bff2f4

…ators

iclementine changed the title ~~add view_as_complex and view_as_real op~~ add as_complex and as_real op Dec 8, 2021

iclementine force-pushed the complex_view branch from a856076 to 0bff2f4 Compare December 8, 2021 11:24

chenfeiyu added 2 commits December 8, 2021 11:25

Merge branch 'develop' of github.com:PaddlePaddle/Paddle into complex…

3c45c2c

…_view

Merge branch 'develop' of github.com:PaddlePaddle/Paddle into complex…

f1f7f4b

…_view

jeff41404 previously approved these changes Dec 9, 2021

View reviewed changes

TCChenlong previously approved these changes Dec 9, 2021

View reviewed changes

XiaoguangHu01 previously approved these changes Dec 9, 2021

View reviewed changes

merge upstream and resolve conflicts

9dcbf5c

iclementine dismissed stale reviews from XiaoguangHu01, TCChenlong, and jeff41404 via 9dcbf5c December 10, 2021 03:21

TCChenlong approved these changes Dec 10, 2021

View reviewed changes

iclementine requested review from XiaoguangHu01 and jeff41404 December 10, 2021 03:34

jeff41404 approved these changes Dec 10, 2021

View reviewed changes

XiaoguangHu01 approved these changes Dec 10, 2021

View reviewed changes

iclementine merged commit ae40370 into PaddlePaddle:develop Dec 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add as_complex and as_real op #37784

add as_complex and as_real op #37784

iclementine commented Dec 2, 2021 •

edited

Loading

paddle-bot-old bot commented Dec 2, 2021

jeff41404 left a comment

pangyoki Dec 2, 2021

iclementine Dec 2, 2021 •

edited

Loading

pangyoki Dec 2, 2021

iclementine Dec 2, 2021

iclementine Dec 2, 2021

pangyoki left a comment

jeff41404 left a comment

TCChenlong left a comment

jeff41404 left a comment

TCChenlong left a comment

XiaoguangHu01 left a comment

TCChenlong left a comment

jeff41404 left a comment

XiaoguangHu01 left a comment

		return np.stack([x.real, x.imag], -1)


		class TestViewAsComplexOp(OpTest):

add as_complex and as_real op #37784

add as_complex and as_real op #37784

Conversation

iclementine commented Dec 2, 2021 • edited Loading

PR types

PR changes

Describe

paddle-bot-old bot commented Dec 2, 2021

jeff41404 left a comment

Choose a reason for hiding this comment

pangyoki Dec 2, 2021

Choose a reason for hiding this comment

iclementine Dec 2, 2021 • edited Loading

Choose a reason for hiding this comment

pangyoki Dec 2, 2021

Choose a reason for hiding this comment

iclementine Dec 2, 2021

Choose a reason for hiding this comment

iclementine Dec 2, 2021

Choose a reason for hiding this comment

pangyoki left a comment

Choose a reason for hiding this comment

jeff41404 left a comment

Choose a reason for hiding this comment

TCChenlong left a comment

Choose a reason for hiding this comment

jeff41404 left a comment

Choose a reason for hiding this comment

TCChenlong left a comment

Choose a reason for hiding this comment

XiaoguangHu01 left a comment

Choose a reason for hiding this comment

TCChenlong left a comment

Choose a reason for hiding this comment

jeff41404 left a comment

Choose a reason for hiding this comment

XiaoguangHu01 left a comment

Choose a reason for hiding this comment

iclementine commented Dec 2, 2021 •

edited

Loading

iclementine Dec 2, 2021 •

edited

Loading