Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add paddle.rad2deg #37598

Merged
merged 5 commits into from
Dec 1, 2021
Merged

Add paddle.rad2deg #37598

merged 5 commits into from
Dec 1, 2021

Conversation

luotao1
Copy link
Contributor

@luotao1 luotao1 commented Nov 26, 2021 •
edited
Loading

PR types

New features

PR changes

APIs

Describe

中文文档PR：PaddlePaddle/docs#4121

  • rad2deg英文文档
    图片
  • deg2rad 英文文档
    图片

@paddle-bot-old
Copy link

paddle-bot-old bot commented Nov 26, 2021 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@luotao1
Copy link
Contributor Author

luotao1 commented Nov 29, 2021 

2021-11-29 17:33:17 ****************

2021-11-29 17:33:17 Please find RD for approval first, and then find TPM for approval.

2021-11-29 17:33:17 0. You must have one RD (XiaoguangHu01, lanxianghit or Superjomn) approval for API change.

2021-11-29 17:33:17  and one TPM approval for API change: 

2021-11-29 17:33:17  jzhang533/ZhangJun, dingjiaweiww/DingJiaWei, TCChenlong/ChenLong, Ligoml/LiMengLiu for general APIs.

2021-11-29 17:33:17  PangHua/XiangHui for distributed related APIs.

2021-11-29 17:33:17  leiqing1/LeiQing for inference related APIs.

2021-11-29 17:33:17 1. You must have one RD (XiaoguangHu01, lanxianghit or Superjomn) approval for API change.

2021-11-29 17:33:17  and one TPM approval for API change: 

2021-11-29 17:33:17  jzhang533/ZhangJun, dingjiaweiww/DingJiaWei, TCChenlong/ChenLong, Ligoml/LiMengLiu for general APIs.

2021-11-29 17:33:17  PangHua/XiangHui for distributed related APIs.

2021-11-29 17:33:17  leiqing1/LeiQing for inference related APIs.

2021-11-29 17:33:17 2. You must have  one TPM approval for API documents change: 

2021-11-29 17:33:17  jzhang533/ZhangJun, dingjiaweiww/DingJiaWei, TCChenlong/ChenLong, Ligoml/LiMengLiu for general API docs.

2021-11-29 17:33:17  PangHua/XiangHui for distributed related API docs.

2021-11-29 17:33:17  leiqing1/LeiQing for inference related API docs.

2021-11-29 17:33:17 
2021-11-29 17:33:17 There are 3 approved errors.

2021-11-29 17:33:17 ****************

2021-11-29 17:33:17 API Difference is: 

2021-11-29 17:33:17 + paddle.deg2rad (ArgSpec(args=['x', 'name'], varargs=None, varkw=None, defaults=(None,), kwonlyargs=[], kwonlydefaults=None, annotations={}), ('document', '7c47dfff7c6d1a85a5e119a3731da1f7'))

2021-11-29 17:33:17 + paddle.rad2deg (ArgSpec(args=['x', 'name'], varargs=None, varkw=None, defaults=(None,), kwonlyargs=[], kwonlydefaults=None, annotations={}), ('document', 'f08d9a728c9d94ba7e8b27ffb6624460'))

jeff41404
jeff41404 previously approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@jeff41404 jeff41404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Superjomn
Superjomn previously approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TCChenlong
TCChenlong previously approved these changes Nov 30, 2021
View reviewed changes
Superjomn
Superjomn approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 8ac0344 into PaddlePaddle:develop Dec 1, 2021
@luotao1 luotao1 deleted the rad2deg branch December 1, 2021 02:37
Zjq9409 pushed a commit to Zjq9409/Paddle that referenced this pull request Dec 10, 2021
@luotao1 @Zjq9409
Add paddle.rad2deg and paddle.deg2rad (PaddlePaddle#37598)
98ef706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Superjomn Superjomn Superjomn approved these changes

@TCChenlong TCChenlong TCChenlong approved these changes

@jeff41404 jeff41404 jeff41404 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luotao1 @Superjomn @jeff41404 @TCChenlong