Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix save inference model conditional op #37579

Merged
merged 1 commit into from
Nov 27, 2021
Merged

fix save inference model conditional op #37579

merged 1 commit into from
Nov 27, 2021

Conversation

JZZ-NOTE
Copy link
Contributor

@JZZ-NOTE JZZ-NOTE commented Nov 26, 2021 •
edited
Loading

PR types

Bug fixes

PR changes

Others

Describe

更新剪裁逻辑：
在以下三种情况，op 会被保留下来：

  1. op 是 target，函数 IsTarget 判断
  2. op 有 dependent outputs，即 op 在 feed 和 target 的通路上，函数 HasDependentOutputVar 判断
  3. 除了以上两种情况以外，涉及到 subblock 的 op 需要特殊处理。如果 op 有 subblock 或者在 subblock 中，并且 op 的 output vars 中有 feed vars，这样的 op 也需要保留下来。函数 IsSubBlockDependent 判断

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@JZZ-NOTE JZZ-NOTE force-pushed the fix_save_inference_model_conditional_op branch from e55cee3 to be15b3f Compare November 26, 2021 13:47
jiweibo
jiweibo approved these changes Nov 27, 2021
View reviewed changes
Copy link
Contributor

@jiweibo jiweibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiweibo jiweibo merged commit fd41456 into PaddlePaddle:develop Nov 27, 2021
Zjq9409 pushed a commit to Zjq9409/Paddle that referenced this pull request Dec 10, 2021
@JZZ-NOTE @Zjq9409
fix save inference model conditional op (PaddlePaddle#37579)
8f0a578
JZZ-NOTE added a commit to JZZ-NOTE/Paddle that referenced this pull request Jan 6, 2022
@JZZ-NOTE
fix save inference model conditional op (PaddlePaddle#37579)
69e117f
Superjomn pushed a commit that referenced this pull request Jan 12, 2022
@JZZ-NOTE
fix save inference model conditional op (#37579) (#38739)
f2a3405
@JZZ-NOTE JZZ-NOTE deleted the fix_save_inference_model_conditional_op branch March 17, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiweibo jiweibo jiweibo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JZZ-NOTE @jiweibo