use ShareBufferWith instead of ShareDataWith for ops with view mechanism #37464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
pangyoki
reviewed
Nov 23, 2021
ShareBufferWith 不会检查 memory size。 |
Zjq9409
pushed a commit
to Zjq9409/Paddle
that referenced
this pull request
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Use ShareBufferWith instead of ShareDataWith for ops with view mechanism.
Change: shape and data type is not shared of operatos with view mechanism. Only holder and offset are shared.
This enables view mechanism between tensors with different data type and shape.