-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PTen] Add full kernel in pten (incomplete) #36930
Conversation
… op2func_refactor
… op2func_refactor
…into op2func_refactor
…into op2func_refactor
Co-authored-by: shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
Thanks for your contribution! |
!ctx.OutputVar("Out")->IsType<framework::SelectedRows>()) { | ||
const auto& str_value = ctx.Attr<std::string>("str_value"); | ||
std::string value = str_value.empty() ? "value" : "str_value"; | ||
return framework::KernelSignature("fill_constant.Scalar", {}, {value}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我们统一使用小写的overloaded name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
paddle/pten/include/infershape.h
Outdated
@@ -15,5 +15,6 @@ limitations under the License. */ | |||
#pragma once | |||
|
|||
// See Note: [ How do we organize the kernel directory ] | |||
#include "paddle/pten/infershape/0_nary.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不建议使用数字命名文件,使用小写字母和下划线,这里是不是直接叫nary.h
就可以
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, 已修改为nary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Others
PR changes
Others
Describe
Add first fill_constant kernel in PTen
The C++ API is: