Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cancel #36740

Merged
merged 24 commits into from
Oct 28, 2021
Merged

Fix cancel #36740

merged 24 commits into from
Oct 28, 2021

Conversation

liutiexing
Copy link
Contributor

@liutiexing liutiexing commented Oct 26, 2021

PR types

Bug fixes

PR changes

Others

Describe

修复WorkQueue的Cancel方法在某一个特定时序下会出现死锁的问题。

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@liutiexing liutiexing closed this Oct 27, 2021
@liutiexing liutiexing reopened this Oct 27, 2021
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghuancoder wanghuancoder merged commit 704e454 into PaddlePaddle:develop Oct 28, 2021
ghost pushed a commit to piotrekobi/Paddle that referenced this pull request Nov 3, 2021
* add align for WorkQueue

* add spinlock

* merge develop

* merge

* Add EventsWaiter

* update

* update

* update Error MSG

* update EventsWaiter

* Add Cancel For ThreadPool

* Add UT for Cancel

* fix Cancel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants