Change the invoking method of settiem from numpy to set_value op when value isn't tensor #35701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… value is not tensor
|
Thanks for your contribution! |
chenwhql
reviewed
Sep 15, 2021
paddle/fluid/pybind/imperative.cc
Outdated
|
|
||
| // cast numpy type form S to T, this may allocate new memory | ||
| template <class T, class S> | ||
| static py::array_t<T> cast_numpy_type(py::array_t<S> array) { |
paddle/fluid/pybind/imperative.cc
Outdated
| } | ||
|
|
||
| template <class T> | ||
| static py::array_t<T> cast_numpy_array(const py::object &array) { |
paddle/fluid/pybind/imperative.cc
Outdated
| "Currently, VarBase.__getitem__() only allows None or integers in " | ||
| "slice item, but received %s.", | ||
| "Currently, slice indices only allows None, integers, and " | ||
| "int of tensor or numpy in slice item, but received %s.", |
paddle/fluid/pybind/imperative.cc
Outdated
| "Currently, VarBase.__getitem__() only allows None or integers in " | ||
| "slice item, but received %s.", | ||
| "Currently, slice indices only allows None, integers, and " | ||
| "int of tensor or numpy in slice item, but received %s.", |
| @@ -408,13 +500,36 @@ static int _PySlice_GetIndices(PySliceObject *r, Py_ssize_t length, | |||
| } else { | |||
| if (PyCheckInteger(r->stop) || IsNumpyType(r->stop)) { | |||
| *stop = PyLong_AsLong(r->stop); | |||
| } else if (PyCheckTensor(r->stop)) { | |||
paddle/fluid/pybind/imperative.cc
Outdated
| @@ -554,7 +669,7 @@ static void ParseIndexingSlice( | |||
|
|
|||
| } else { | |||
| PADDLE_THROW(platform::errors::InvalidArgument( | |||
| "Currently, VarBase.__getitem__() only allows indexing " | |||
| "Currently, VarBase.__indices__() only allows indexing " | |||
AnnaTrainingG
pushed a commit
to AnnaTrainingG/Paddle
that referenced
this pull request
Sep 29, 2021
… value isn't tensor (PaddlePaddle#35701) * Change the invoking method of settiem from numpy to set_value op when value is not tensor * fix the check logic for inplace in setitem * fix the unittest problem caused by setitem doesn't support fp16 * modify some code format in setitem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Describe
Change the invoking method of settiem from numpy to set_value op when value isn't tensor
当执行如下代码时：( 右边的值为非tensor)
修改前的setitem由numpy完成底层逻辑处理
修改后的setitem由set_value op完成底层逻辑处理