Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sgd trainer document error. #3526

Merged
merged 4 commits into from
Aug 16, 2017
Merged

Fix sgd trainer document error. #3526

merged 4 commits into from
Aug 16, 2017

Conversation

wanghaoshuang
Copy link
Contributor

fix #3525

typhoonzero
typhoonzero reviewed Aug 16, 2017
View reviewed changes
python/paddle/v2/trainer.py Outdated
:type extra_layers: paddle.v2.config_base.Layer
:param is_local: Whether trainning locally
:type is_local: bool
:param pserver_spec: pserver location, eg: localhost:3000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pserver location, eg: localhost:3000, if use_etcd is true, pserver_spec indicates the etcd endpoints, eg: http://127.0.0.1:2379

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thks.

typhoonzero
typhoonzero approved these changes Aug 16, 2017
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Yancey1989
Yancey1989 reviewed Aug 16, 2017
View reviewed changes
python/paddle/v2/trainer.py Outdated
:type extra_layers: paddle.v2.config_base.Layer
:param is_local: Whether trainning locally
:type is_local: bool
:param pserver_spec: pserver location, eg: localhost:3000,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps there is more than one PServer instance, and just used for fault tolerant mode

pserver location, eg: localhost:3000

=>

comma string for pserver location, eg:127.10.0.10:3000,127.10.0.11:3000, and this parameter is only used for fault tolerant mode cluster training.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@wanghaoshuang wanghaoshuang merged commit 462d3e9 into PaddlePaddle:develop Aug 16, 2017
@wanghaoshuang wanghaoshuang deleted the fix_sgd_doc branch August 16, 2017 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yancey1989 Yancey1989 Yancey1989 left review comments

@typhoonzero typhoonzero typhoonzero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix sgd trainer document error.
3 participants
@wanghaoshuang @Yancey1989 @typhoonzero