[oneDNN ] disabling more ops caching #34830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix in compilation - compilation fix - transpose caching disabled - compilation fix - more compilation fixes - sum caching disabled - compilation fix
|
Thanks for your contribution! |
jakpiase
reviewed
Aug 16, 2021
| this->dev_ctx_.SetBlob(key_pd, this->fwd_pd_); | ||
| } | ||
| this->fwd_pd_.reset( | ||
| new dnnl::sum::primitive_desc(dst_md, scales, srcs_md, this->engine_)); |
There was a problem hiding this comment.
You are using "new" here. Is it later destroyed anywhere?
There was a problem hiding this comment.
this->fwd_pd_ is a shared pointer so when reference count will get to zero then deallocation of of object will happen . So we do not have to worry about memory leaks.
There was a problem hiding this comment.
Ok, thanks. I didn't see that it is a smart pointer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
Recently oneDNN introduced caching of its elements: primitives and primitives descriptors so we can disable partially our own caching. This PR disabled caching of LRN, Transpose, Layer Norm and Sum oneDNN ops