Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI file revision check bug #34445

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Jul 28, 2021

PR types

Others

PR changes

Others

Describe

CI check_file_diff_approvals.sh have the following bug.

~ % echo "paddle/fluid/framework/ir/graph_helper.h" | grep "paddle/fluid/framework/ir/graph.h"
paddle/fluid/framework/ir/graph_helper.h

It is because grep would use regular expression by default. To disable regular expression, use grep -F instead. See: https://stackoverflow.com/questions/9416390/grep-not-as-a-regular-expression

~ % echo "paddle/fluid/framework/ir/graph_helper.h" | grep -F "paddle/fluid/framework/ir/graph.h" | wc -l
0
~ % echo "paddle/fluid/framework/ir/graph.h" | grep -F "paddle/fluid/framework/ir/graph.h"
paddle/fluid/framework/ir/graph.h

@CLAassistant
Copy link

CLAassistant commented Jul 28, 2021

CLA assistant check
All committers have signed the CLA.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lelelelelez lelelelelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy merged commit 0b2e510 into PaddlePaddle:develop Jul 28, 2021
@sneaxiy sneaxiy deleted the fix_ci_check_approval branch July 28, 2021 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants