Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add constructors to OperatorBase and all sub-classes #3430

Merged
merged 4 commits into from
Aug 11, 2017
Merged

Add constructors to OperatorBase and all sub-classes #3430

merged 4 commits into from
Aug 11, 2017

Conversation

wangkuiyi
Copy link
Collaborator

@wangkuiyi wangkuiyi commented Aug 11, 2017 •
edited
Loading

Fixes #3429

JiayiFeng
JiayiFeng reviewed Aug 11, 2017
View reviewed changes
paddle/framework/backward_test.cc
@@ -30,6 +30,11 @@ using DeviceContext = platform::DeviceContext;

class EmptyOp : public OperatorBase {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be named NOP?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We can create another PR to fix it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we can fix it in following prs.

JiayiFeng
JiayiFeng approved these changes Aug 11, 2017
View reviewed changes
Copy link
Collaborator

@JiayiFeng JiayiFeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangkuiyi wangkuiyi merged commit 38f4b1d into PaddlePaddle:develop Aug 11, 2017
@wangkuiyi wangkuiyi deleted the add_operatorbase_constructors branch August 11, 2017 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiayiFeng JiayiFeng JiayiFeng approved these changes

@Superjomn Superjomn Awaiting requested review from Superjomn

@reyoung reyoung Awaiting requested review from reyoung

@jacquesqiao jacquesqiao Awaiting requested review from jacquesqiao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangkuiyi @JiayiFeng