-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add auto gradient check design doc #3410
add auto gradient check design doc #3410
Conversation
doc/design/auto_gradient_check.md
Outdated
@@ -0,0 +1,146 @@ | |||
## auto gradient check Design |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto gradient check Design => Auto Gradient Check Design
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
doc/design/auto_gradient_check.md
Outdated
|
||
## Backgraound: | ||
- Operator forward computing is easy to check if the result is right because it has a clear definition. **But** backpropagation is a notoriously difficult algorithm to debug and get right: | ||
- **Firstly** you should get the right backpropagation formula according to the forward computation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 1.
would be OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
doc/design/auto_gradient_check.md
Outdated
- **Firstly** numeric gradient checker only need forward operator. | ||
- **Secondly** user only need to prepare the input data for forward Operator. | ||
|
||
## mathematical theory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Titles should Capitalize the first character.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Fix #3353
here is better for review.