bugfix: param init with fill constant str_value #33381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
JZ-LIANG
added a commit
to JZ-LIANG/Paddle
that referenced
this pull request
Jun 9, 2021
fuyinno4
pushed a commit
that referenced
this pull request
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
in fp64 setting, user set beta1_pow_acc = 0.9, beta2_pow_acc = 0.999 for adamw,
before bugfix the actual value are: beta1_pow_acc = 0.8999999761581421, beta2_pow_acc = 0.9990000128746033
after bugfix the actual value are: beta1_pow_acc = 0.9000000000000000, beta2_pow_acc = 0.9990000000000000
fill constant should set str_value attr to preserve precision in fp64 setting