-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new operation: BroadcastTensorsOp, test=develop #33294
Conversation
Thanks for your contribution! |
Sorry to inform you that ac0d714's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments
python/paddle/fluid/tests/unittests/test_broadcast_tensors_op.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# out1, out2, out3: tensors broadcasted from x1, x2, x3 with shape [1,2,3,4] | ||
""" | ||
|
||
num_inputs = len(input) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个值一定需要从python端获取吗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
与秋良确认了一下:
- 目前自动代码生成确实需要产生一个OutNum,后面如果出现较多类似broadcast_tensors的情况,考虑更新自动代码生成逻辑
- 目前来看多传入一个int num_inputs对性能影响不大
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
53a3b06
cd34c1e
PR types
New features
PR changes
OPs
Describe
API:
Code position:
Example:
CN Doc PR: PaddlePaddle/docs#3606