Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API paddle.neg() and paddle.lgamma(), along with some unittests for paddle.neg(). #33248

Merged
merged 10 commits into from
Jun 9, 2021
Merged

Conversation

levi131
Copy link
Contributor

@levi131 levi131 commented Jun 1, 2021

PR types

New features

PR changes

APIs

Describe

1、Add API "paddle.neg()", which alias "paddle.tensor.neg(), paddle.tensor.math.neg()" and is implemented with interface "paddle.scale()".
2、Add API "paddle.lgamma()", which alias "paddle.tensor.lgamma(), paddle.tensor.math.lgamma()"

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jun 1, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Aurelius84
Aurelius84 previously approved these changes Jun 4, 2021
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhhsplendid
zhhsplendid previously approved these changes Jun 4, 2021
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lanxianghit
lanxianghit previously approved these changes Jun 4, 2021
Copy link
Contributor

@lanxianghit lanxianghit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,请同时提交中文文档pr

@levi131 levi131 dismissed stale reviews from lanxianghit, zhhsplendid, and Aurelius84 via bfc10c9 June 4, 2021 11:16
@levi131 levi131 changed the title Add API paddle.neg() and unittest. Add API paddle.neg() and unittest and add API paddle.lgamma(). Jun 4, 2021
@levi131 levi131 changed the title Add API paddle.neg() and unittest and add API paddle.lgamma(). Add API paddle.neg() and paddle.lgamma(), along with some unittests for paddle.neg(). Jun 4, 2021
@levi131
Copy link
Contributor Author

levi131 commented Jun 8, 2021

image

@levi131
Copy link
Contributor Author

levi131 commented Jun 8, 2021

image

Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 merged commit 9cda9ec into PaddlePaddle:develop Jun 9, 2021
@levi131 levi131 deleted the levi/add_neg_op_3 branch June 10, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants