-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify all external API error message mechanism and enhance third-party API error msg #33003
Conversation
Thanks for your contribution! |
431b94f
to
94fd398
Compare
94fd398
to
34f1ea3
Compare
34f1ea3
to
598b4f1
Compare
598b4f1
to
3a14c9e
Compare
3a14c9e
to
8414466
Compare
8414466
to
99a9647
Compare
99a9647
to
3095230
Compare
3095230
to
c1f176b
Compare
c1f176b
to
a26b191
Compare
tools/externalError/spider.py
Outdated
@@ -0,0 +1,363 @@ | |||
# Copyright (c) 2020 PaddlePaddle Authors. All Rights Reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2020->2021?
// Version of cuda API | ||
required int32 version = 1; | ||
// Indicates which kind of third-party API | ||
required ApiType type = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not need verison now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
现在分了6种API,每种API取了一个网址,如果再分小版本就太多了。因为低版本API都是包含在高版本里,现在用的CUDA11.2 是比较全的
paddle/fluid/platform/enforce.h
Outdated
namespace details { | ||
|
||
template <typename T> | ||
struct CudaStatusType {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CudaStatusType命名是不是不太严谨,用NvidiaLib或者别的?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
用了ExternalApiType,看是用NvidiaApiType还是?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
New features
PR changes
Others
Describe
1. 统一所有外部API报错消息机制,使用
external_error.proto
进行统一管理;2. 新增强CURAND、CUDNN、CUBLAS、CUSOLVER、NCCL五种Nvidia类型API的报错信息,打印出详细的Hint提示内容,竞品只给出报错码;
1). CURAND API:
2). CUDNN API:
3). CUBLAS API:
4). CUSOLVER API:
5). NCCL API:
6). CUDA API:
共包括116种错误类型与报错信息,不进行改动,在1.8已经进行支持;
缺省信息:
上述所有API如果无法查找到爬虫中对应的错误码,将会默认打印: