Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Modified the docs of some api for supporting list/tuple args. #32360

Merged
merged 9 commits into from
Apr 27, 2021
Merged

[Docs] Modified the docs of some api for supporting list/tuple args. #32360

merged 9 commits into from
Apr 27, 2021

Conversation

xiemoyuan
Copy link
Contributor

@xiemoyuan xiemoyuan commented Apr 19, 2021 •
edited
Loading

PR types

Others

PR changes

Docs

Describe

Modified and completed the docs of some api, which originally supported list/tuple args, when deal with this iCafe.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

jzhang533
jzhang533 approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xiemoyuan xiemoyuan changed the title Fixed docs. [Docs] Modified the docs of some api for supporting list/tuple args. Apr 26, 2021
chenwhql
chenwhql approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

raindrops2sea
raindrops2sea approved these changes Apr 26, 2021
View reviewed changes
Copy link
Collaborator

@raindrops2sea raindrops2sea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiqiu
Copy link
Contributor

zhiqiu commented Apr 27, 2021 •
edited
Loading

Better add unit tests for the changed APIs to ensure that list/tuple args are supported well.

zhiqiu
zhiqiu approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM，plz add tests in next PR.

@XiaoguangHu01 XiaoguangHu01 merged commit 1515892 into PaddlePaddle:develop Apr 27, 2021
@xiemoyuan xiemoyuan deleted the fix-docs branch April 27, 2021 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzhang533 jzhang533 jzhang533 approved these changes

@zhiqiu zhiqiu zhiqiu approved these changes

@chenwhql chenwhql chenwhql approved these changes

@raindrops2sea raindrops2sea raindrops2sea approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xiemoyuan @zhiqiu @jzhang533 @chenwhql @raindrops2sea @XiaoguangHu01