Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified the return value of tensor.grad from numpy to tensor. #32142

Merged
merged 8 commits into from
Apr 26, 2021
Merged

Modified the return value of tensor.grad from numpy to tensor. #32142

merged 8 commits into from
Apr 26, 2021

Conversation

xiemoyuan
Copy link
Contributor

PR types

Function optimization

PR changes

APIs

Describe

Modified the return value of tensor.grad from numpy to tensor.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Apr 8, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

willthefrog
willthefrog previously approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@willthefrog willthefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhwesky2010
zhwesky2010 reviewed Apr 20, 2021
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不兼容面可能有点大，可能需要把不少模型x.grad也都改过来

jzhang533
jzhang533 reviewed Apr 21, 2021
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这是个不兼容升级。

  • 需要评估看看模型套件里对该API的使用情况。
  • 根据结果我们讨论一下是直接这么修改，还是有一个过渡期。（e.g.：2.1版本只给出warning）

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Apr 22, 2021
@PaddlePaddle PaddlePaddle unlocked this conversation Apr 22, 2021
jzhang533
jzhang533 approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

XiaoguangHu01
XiaoguangHu01 approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XiaoguangHu01 XiaoguangHu01 merged commit c40c16a into PaddlePaddle:develop Apr 26, 2021
@xiemoyuan xiemoyuan deleted the tensor-grad branch April 26, 2021 07:35
@pangyoki pangyoki mentioned this pull request Apr 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhwesky2010 zhwesky2010 zhwesky2010 left review comments

@jzhang533 jzhang533 jzhang533 approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@willthefrog willthefrog willthefrog left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xiemoyuan @jzhang533 @willthefrog @XiaoguangHu01 @zhwesky2010