Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ScopePtr and OperatorPtr #3027

Merged
merged 1 commit into from
Jul 24, 2017
Merged

Remove ScopePtr and OperatorPtr #3027

merged 1 commit into from
Jul 24, 2017

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Jul 24, 2017

  • ScopePtr means pointer of scope, but it can be shared or uniqued.
    Change it to std::shared_ptr to make code better to read.

@reyoung
Remove ScopePtr and OperatorPtr
c2543f5 
* ScopePtr means pointer of scope, but it can be shared or uniqued.
Change it to std::shared_ptr<Scope> to make code better to read.
@reyoung reyoung requested a review from jacquesqiao July 24, 2017 07:24
jacquesqiao
jacquesqiao approved these changes Jul 24, 2017
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@reyoung reyoung merged commit 477c835 into PaddlePaddle:develop Jul 24, 2017
@reyoung reyoung mentioned this pull request Jul 24, 2017
Closed
@reyoung reyoung deleted the feature/remove_scope_ptr branch July 26, 2017 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacquesqiao jacquesqiao jacquesqiao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reyoung @jacquesqiao