Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataLoader support not auto collate batch #28425

Merged
merged 11 commits into from
Nov 16, 2020
Merged

DataLoader support not auto collate batch #28425

merged 11 commits into from
Nov 16, 2020

Conversation

heavengate
Copy link
Contributor

@heavengate heavengate commented Nov 4, 2020 •
edited
Loading

PR types

Function optimization

PR changes

APIs

Describe

DataLoader support not auto collating batch when batch_size is set as None

屏幕快照 2020-11-11 下午3 32 51

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Nov 4, 2020

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@heavengate heavengate force-pushed the dataloader_collate_batch branch from 886c19f to 5c4d0ec Compare November 4, 2020 14:49
@heavengate heavengate mentioned this pull request Nov 10, 2020
Merged
chenwhql
chenwhql reviewed Nov 12, 2020
View reviewed changes
Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

python/paddle/fluid/reader.py Outdated
@@ -163,6 +163,21 @@ class DataLoader(object):

For :code:`batch_sampler` please see :code:`paddle.io.BatchSampler`

**Disable automatic batching**

In certain cases such as some NLP task, instead of automatic batching,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some task -> some tasks?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks!

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Nov 12, 2020
@PaddlePaddle PaddlePaddle unlocked this conversation Nov 12, 2020
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Nov 12, 2020
@PaddlePaddle PaddlePaddle unlocked this conversation Nov 12, 2020
@heavengate heavengate closed this Nov 14, 2020
@heavengate heavengate reopened this Nov 14, 2020
saxon-zh
saxon-zh approved these changes Nov 16, 2020
View reviewed changes
Copy link

@saxon-zh saxon-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heavengate heavengate merged commit 89d27de into PaddlePaddle:develop Nov 16, 2020
@heavengate heavengate deleted the dataloader_collate_batch branch November 16, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saxon-zh saxon-zh saxon-zh approved these changes

@chenwhql chenwhql chenwhql approved these changes

@qingqing01 qingqing01 Awaiting requested review from qingqing01

@XiaoguangHu01 XiaoguangHu01 Awaiting requested review from XiaoguangHu01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heavengate @CLAassistant @saxon-zh @chenwhql