-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rdma cmake support #284
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
# user should download rdma first from subversion repository | ||
|
||
# execute following instruction to download svn mannally | ||
# svn co https://svn.baidu.com/sys/ip/trunk/rdma/sockrdmav1 rdma/ | ||
# svn co https://svn.baidu.com/sys/ip/trunk/rdma/thirdparty rdma/ | ||
# we use static output in svn repositories to avoid implict bugs from not standard runtime env. | ||
|
||
set(RDMA_ROOT $ENV{RDMA_ROOT} CACHE PATH "Folder contains RDMA sock library and thirdparty library") | ||
|
||
function(generate_rdma_links) | ||
#redirect to current DIR to isolate the pollution from system runtime environment | ||
#it can benifits unified control for different gcc environment. | ||
#e.g, by default gcc48 did not refer /usr/lib64 which could contain low version | ||
#runtime libraries that will crash process while loading it. That redirect trick | ||
#can fix it. | ||
execute_process( | ||
COMMAND mkdir -p librdma | ||
COMMAND ln -s -f /usr/lib64/libibverbs.so.1.0.0 librdma/libibverbs.so.1 | ||
COMMAND ln -s -f /usr/lib64/libibverbs.so.1.0.0 librdma/libibverbs.so | ||
COMMAND ln -s -f /usr/lib64/librdmacm.so.1.0.0 librdma/librdmacm.so.1 | ||
COMMAND ln -s -f /usr/lib64/librdmacm.so.1.0.0 librdma/librdmacm.so | ||
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR} | ||
) | ||
endfunction(generate_rdma_links) | ||
|
||
|
||
#check and set headers | ||
find_path(RDMA_INC_SXISOCK sxi_sock.h PATHS ${RDMA_ROOT}/sockrdmav1/output/include) | ||
find_path(RDMA_INC_XIO libxio.h PATHS ${RDMA_ROOT}/thirdparty/output/accelio) | ||
find_path(RDMA_INC_EVENT event2 PATHS ${RDMA_ROOT}/thirdparty/output/libevent) | ||
find_path(RDMA_INC_NUMA numa.h PATHS ${RDMA_ROOT}/thirdparty/output/libnuma) | ||
|
||
#check and set libs | ||
find_library(RDMA_LIB_SXISOCK NAMES sxisock PATHS ${RDMA_ROOT}/sockrdmav1/output) | ||
find_library(RDMA_LIB_XIO NAMES xio PATHS ${RDMA_ROOT}/thirdparty/output/accelio) | ||
find_library(RDMA_LIB_EVENT NAMES event PATHS ${RDMA_ROOT}/thirdparty/output/libevent) | ||
find_library(RDMA_LIB_EVENT_CORE NAMES event_core PATHS ${RDMA_ROOT}/thirdparty/output/libevent) | ||
find_library(RDMA_LIB_EVENT_EXTRA NAMES event_extra PATHS ${RDMA_ROOT}/thirdparty/output/libevent) | ||
find_library(RDMA_LIB_EVENT_PTHREADS NAMES event_pthreads PATHS ${RDMA_ROOT}/thirdparty/output/libevent) | ||
find_library(RDMA_LIB_NUMA NAMES numa PATHS ${RDMA_ROOT}/thirdparty/output/libnuma) | ||
|
||
if( | ||
RDMA_INC_SXISOCK AND | ||
RDMA_INC_XIO AND | ||
RDMA_INC_EVENT AND | ||
RDMA_INC_NUMA AND | ||
RDMA_LIB_SXISOCK AND | ||
RDMA_LIB_XIO AND | ||
RDMA_LIB_EVENT AND | ||
RDMA_LIB_EVENT_CORE AND | ||
RDMA_LIB_EVENT_EXTRA AND | ||
RDMA_LIB_EVENT_PTHREADS AND | ||
RDMA_LIB_NUMA | ||
) | ||
|
||
set(RDMA_INC_DIR | ||
${RDMA_INC_SXISOCK} | ||
${RDMA_INC_XIO} | ||
${RDMA_INC_EVENT} | ||
${RDMA_INC_NUMA}) | ||
set(RDMA_LIBS | ||
${RDMA_LIB_SXISOCK} | ||
${RDMA_LIB_XIO} | ||
${RDMA_LIB_EVENT} | ||
${RDMA_LIB_EVENT_CORE} | ||
${RDMA_LIB_EVENT_EXTRA} | ||
${RDMA_LIB_EVENT_PTHREADS} | ||
${RDMA_LIB_NUMA} | ||
) | ||
set(RDMA_LD_FLAGS "-L./librdma -libverbs -lrdmacm -Xlinker -rpath ./librdma") | ||
return() | ||
endif() | ||
|
||
#if this module is not called, RDMA_INC_DIR RDMA_LIBS will be null, so top module always refer this variable | ||
|
||
message(FATAL_ERROR, "RDMA libraries are not found, try to set RDMA_ROOT or check all related libraries.") |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
其实我的意思是,这个ln为什么不能只做一遍?而需要在编译每个binary的时候都做?
在这里,如果我吧generate_rdma_links这个函数删除掉,在这个cmake文件里直接做
然后加一行
然后,后面其他的库,直接引用这个RDMA_HOME不可以么?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
因为我们实际上加了一个rpath
这个要求链接出来的二进制要跟这个librdma在一个目录,但是cmake会使得test_BLABLA程序在不同的test子目录,所以要为每一个test创建一个librdma, 否则单测的时候会挂在程序加载阶段。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, 了解了。